Skip to content

[OpenVINO backend] support categorical #21437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025

Conversation

Mohamed-Ashraf273
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2025

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.81%. Comparing base (d55a767) to head (950bdeb).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
keras/src/backend/openvino/random.py 93.54% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21437   +/-   ##
=======================================
  Coverage   82.81%   82.81%           
=======================================
  Files         565      565           
  Lines       55520    55551   +31     
  Branches     8664     8665    +1     
=======================================
+ Hits        45977    46006   +29     
- Misses       7428     7429    +1     
- Partials     2115     2116    +1     
Flag Coverage Δ
keras 82.62% <93.54%> (+<0.01%) ⬆️
keras-jax 63.35% <0.00%> (-0.04%) ⬇️
keras-numpy 58.55% <0.00%> (-0.04%) ⬇️
keras-openvino 34.04% <93.54%> (+0.05%) ⬆️
keras-tensorflow 63.80% <0.00%> (-0.04%) ⬇️
keras-torch 63.46% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gbaned gbaned added this to PR Queue Jun 30, 2025
@github-project-automation github-project-automation bot moved this to Assigned Reviewer in PR Queue Jun 30, 2025
@gbaned gbaned requested a review from mattdangerw June 30, 2025 08:19
@Mohamed-Ashraf273 Mohamed-Ashraf273 force-pushed the support_categorical branch 4 times, most recently from c825e0e to 4b68377 Compare July 4, 2025 20:48
@Mohamed-Ashraf273
Copy link
Contributor Author

@rkazants

Copy link
Contributor

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fchollet, looks good to me. Recommend to merge.

@Mohamed-Ashraf273
Copy link
Contributor Author

@fchollet

@fchollet fchollet merged commit f2b8b92 into keras-team:master Jul 24, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Assigned Reviewer to Merged in PR Queue Jul 24, 2025
@Mohamed-Ashraf273 Mohamed-Ashraf273 deleted the support_categorical branch July 24, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

5 participants